diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2018-05-10 13:26:16 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-05-11 11:56:05 -0400 |
| commit | 8ccc113172e4c1ebef45c2433f3c32ed6ae1b9c9 (patch) | |
| tree | f99ca86a37d6f85091b9587d9b04be8c4190b7cd /drivers | |
| parent | 89dd2e752c7beb773c36e623773d50d5f34da711 (diff) | |
| download | linux-8ccc113172e4c1ebef45c2433f3c32ed6ae1b9c9.tar.bz2 | |
mlxsw: core: Fix an error handling path in 'mlxsw_core_bus_device_register()'
Resources are not freed in the reverse order of the allocation.
Labels are also mixed-up.
Fix it and reorder code and labels in the error handling path of
'mlxsw_core_bus_device_register()'
Fixes: ef3116e5403e ("mlxsw: spectrum: Register KVD resources with devlink")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c index 93ea56620a24..e13ac3b8dff7 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/core.c +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c @@ -1100,11 +1100,11 @@ err_emad_init: err_alloc_lag_mapping: mlxsw_ports_fini(mlxsw_core); err_ports_init: - mlxsw_bus->fini(bus_priv); -err_bus_init: if (!reload) devlink_resources_unregister(devlink, NULL); err_register_resources: + mlxsw_bus->fini(bus_priv); +err_bus_init: if (!reload) devlink_free(devlink); err_devlink_alloc: |