diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-10-16 19:35:11 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-10-17 22:08:55 -0700 |
| commit | e519869af368fe1da218b43bdb3a553d66f4fcd0 (patch) | |
| tree | 5509b9ce22e3653022ab50d415a75d39a596238f /drivers | |
| parent | 33c4368ee2589c165aebd8d388cbd91e9adb9688 (diff) | |
| download | linux-e519869af368fe1da218b43bdb3a553d66f4fcd0.tar.bz2 | |
net: phy: mscc: fix signedness bug in vsc85xx_downshift_get
Currently, the error handling for the call to function
phy_read_paged() doesn't work because *reg_val* is of
type u16 (16 bits, unsigned), which makes it impossible
for it to hold a value less than 0.
Fix this by changing the type of variable *reg_val* to int.
Addresses-Coverity-ID: 1473970 ("Unsigned compared against 0")
Fixes: 6a0bfbbe20b0 ("net: phy: mscc: migrate to phy_select/restore_page functions")
Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/phy/mscc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index bffe077dc75f..bff56c343448 100644 --- a/drivers/net/phy/mscc.c +++ b/drivers/net/phy/mscc.c @@ -522,7 +522,7 @@ static int vsc85xx_mdix_set(struct phy_device *phydev, u8 mdix) static int vsc85xx_downshift_get(struct phy_device *phydev, u8 *count) { - u16 reg_val; + int reg_val; reg_val = phy_read_paged(phydev, MSCC_PHY_PAGE_EXTENDED, MSCC_PHY_ACTIPHY_CNTL); |