diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-01-20 10:46:54 +0000 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2022-02-01 11:07:59 +0100 |
| commit | ba18dad0fb880cd29aa97b6b75560ef14d1061ba (patch) | |
| tree | 169a68969ba92f14ba7a531bd62de868f1cdf4e1 /drivers | |
| parent | 2b7950c7ac9117a18f1790fcea819cb69380e5bd (diff) | |
| download | linux-ba18dad0fb880cd29aa97b6b75560ef14d1061ba.tar.bz2 | |
power: reset: gemini-poweroff: Fix IRQ check in gemini_poweroff_probe
platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:
int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
Fix the check of return value to catch errors correctly.
Fixes: f7a388d6cd1c ("power: reset: Add a driver for the Gemini poweroff")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/power/reset/gemini-poweroff.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/power/reset/gemini-poweroff.c b/drivers/power/reset/gemini-poweroff.c index 90e35c07240a..b7f7a8225f22 100644 --- a/drivers/power/reset/gemini-poweroff.c +++ b/drivers/power/reset/gemini-poweroff.c @@ -107,8 +107,8 @@ static int gemini_poweroff_probe(struct platform_device *pdev) return PTR_ERR(gpw->base); irq = platform_get_irq(pdev, 0); - if (!irq) - return -EINVAL; + if (irq < 0) + return irq; gpw->dev = dev; |