diff options
| author | Jörn Engel <joern@logfs.org> | 2012-05-11 10:33:41 -0400 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-05-11 15:01:48 -0700 |
| commit | d28d96dcf635410422b41eca5203b0470dd059c1 (patch) | |
| tree | 1be69678d962cfaa08d8fafdaaa34c2f2b9ed157 /drivers | |
| parent | 11e764bd5ed4bb930e0ec5dd161df58307507347 (diff) | |
| download | linux-d28d96dcf635410422b41eca5203b0470dd059c1.tar.bz2 | |
target: cleanup transport_execute_tasks()
The function is effectively void and doesn't need any goto logic.
Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/target/target_core_transport.c | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 59577568f935..397e8bd4d596 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -1970,7 +1970,7 @@ static inline int transport_execute_task_attr(struct se_cmd *cmd) * Called from fabric module context in transport_generic_new_cmd() and * transport_generic_process_write() */ -static int transport_execute_tasks(struct se_cmd *cmd) +static void transport_execute_tasks(struct se_cmd *cmd) { int add_tasks; struct se_device *se_dev = cmd->se_dev; @@ -1984,16 +1984,12 @@ static int transport_execute_tasks(struct se_cmd *cmd) * attribute for the tasks of the received struct se_cmd CDB */ add_tasks = transport_execute_task_attr(cmd); - if (!add_tasks) - goto execute_tasks; - - __transport_execute_tasks(se_dev, cmd); - return 0; + if (add_tasks) { + __transport_execute_tasks(se_dev, cmd); + return; + } } - -execute_tasks: __transport_execute_tasks(se_dev, NULL); - return 0; } static int __transport_execute_tasks(struct se_device *dev, struct se_cmd *new_cmd) |