diff options
| author | Marc Zyngier <maz@kernel.org> | 2020-11-29 13:55:25 +0000 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2020-12-11 14:45:22 +0000 |
| commit | 3841245e8498a789c65dedd7ffa8fb2fee2c0684 (patch) | |
| tree | 2f4335c7b5eba12acc391ace1ee7b69eb9817e55 /drivers | |
| parent | 9898a59358d7cb925f63bb77bd40224d1bc4857e (diff) | |
| download | linux-3841245e8498a789c65dedd7ffa8fb2fee2c0684.tar.bz2 | |
irqchip/alpine-msi: Fix freeing of interrupts on allocation error path
The alpine-msi driver has an interesting allocation error handling,
where it frees the same interrupts repeatedly. Hilarity follows.
This code is probably never executed, but let's fix it nonetheless.
Fixes: e6b78f2c3e14 ("irqchip: Add the Alpine MSIX interrupt controller")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Antoine Tenart <atenart@kernel.org>
Cc: Tsahee Zidenberg <tsahee@annapurnalabs.com>
Cc: Antoine Tenart <atenart@kernel.org>
Link: https://lore.kernel.org/r/20201129135525.396671-1-maz@kernel.org
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/irqchip/irq-alpine-msi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c index 23a3b877f7f1..ede02dc2bcd0 100644 --- a/drivers/irqchip/irq-alpine-msi.c +++ b/drivers/irqchip/irq-alpine-msi.c @@ -165,8 +165,7 @@ static int alpine_msix_middle_domain_alloc(struct irq_domain *domain, return 0; err_sgi: - while (--i >= 0) - irq_domain_free_irqs_parent(domain, virq, i); + irq_domain_free_irqs_parent(domain, virq, i - 1); alpine_msix_free_sgi(priv, sgi, nr_irqs); return err; } |