summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorShannon Nelson <shannon.nelson@intel.com>2013-11-20 10:02:58 +0000
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2013-12-06 17:20:39 -0800
commitc140c17b98f246d736e20757e39ec597fae7bc9e (patch)
tree0500276c476e66ebccbb49cb9b413a603cc26cc2 /drivers
parentac6c5e3d0e9e784ef8b015085c83dee0253324b0 (diff)
downloadlinux-c140c17b98f246d736e20757e39ec597fae7bc9e.tar.bz2
i40e: clear test state bit after all ethtool tests
Fix a bug where the TESTING state was still set when exiting the ethtool diagnostics. Change-Id: Ic47950d2e86a67167d1d282256d477cecd86d820 Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/ethernet/intel/i40e/i40e_ethtool.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 7fb669bd0472..44d4a7f84787 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -805,9 +805,10 @@ static void i40e_diag_test(struct net_device *netdev,
data[I40E_ETH_TEST_EEPROM] = 0;
data[I40E_ETH_TEST_INTR] = 0;
data[I40E_ETH_TEST_LOOPBACK] = 0;
-
- clear_bit(__I40E_TESTING, &pf->state);
}
+ clear_bit(__I40E_TESTING, &pf->state);
+
+ netdev_info(netdev, "testing finished\n");
}
static void i40e_get_wol(struct net_device *netdev,