diff options
author | Eric Dumazet <edumazet@google.com> | 2014-06-06 06:44:03 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-06-08 14:15:14 -0700 |
commit | 87757a917b0b3c0787e0563c679762152be81312 (patch) | |
tree | ffc8bfa37fc3db09ac90bff273fbf13085e8d558 /drivers | |
parent | ba6de0f5304ccdc45ae260e7e0feb6e0ef2dd558 (diff) | |
download | linux-87757a917b0b3c0787e0563c679762152be81312.tar.bz2 |
net: force a list_del() in unregister_netdevice_many()
unregister_netdevice_many() API is error prone and we had too
many bugs because of dangling LIST_HEAD on stacks.
See commit f87e6f47933e3e ("net: dont leave active on stack LIST_HEAD")
In fact, instead of making sure no caller leaves an active list_head,
just force a list_del() in the callee. No one seems to need to access
the list after unregister_netdevice_many()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/macvlan.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index d53e299ae1d9..7eec598c5cb6 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -1036,7 +1036,6 @@ static int macvlan_device_event(struct notifier_block *unused, list_for_each_entry_safe(vlan, next, &port->vlans, list) vlan->dev->rtnl_link_ops->dellink(vlan->dev, &list_kill); unregister_netdevice_many(&list_kill); - list_del(&list_kill); break; case NETDEV_PRE_TYPE_CHANGE: /* Forbid underlaying device to change its type. */ |