diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2020-08-24 11:12:30 +0800 |
|---|---|---|
| committer | Wim Van Sebroeck <wim@linux-watchdog.org> | 2020-10-14 15:02:24 +0200 |
| commit | 937425d4cd3ae4e2882b41e332bbbab616bcf0ad (patch) | |
| tree | 8f04bc22716d3f6fd0bfae157a96fe5be869b005 /drivers/watchdog | |
| parent | 5afb6d203d0293512aa2c6ae098274a2a4f6ed02 (diff) | |
| download | linux-937425d4cd3ae4e2882b41e332bbbab616bcf0ad.tar.bz2 | |
watchdog: Use put_device on error
We should use put_device() instead of freeing device
directly after device_initialize().
Fixes: cb36e29bb0e4b ("watchdog: initialize device before misc_register")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20200824031230.31050-1-dinghao.liu@zju.edu.cn
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Diffstat (limited to 'drivers/watchdog')
| -rw-r--r-- | drivers/watchdog/watchdog_dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c index 785270ee337c..bcf01af3fa6a 100644 --- a/drivers/watchdog/watchdog_dev.c +++ b/drivers/watchdog/watchdog_dev.c @@ -1023,7 +1023,7 @@ static int watchdog_cdev_register(struct watchdog_device *wdd) pr_err("%s: a legacy watchdog module is probably present.\n", wdd->info->identity); old_wd_data = NULL; - kfree(wd_data); + put_device(&wd_data->dev); return err; } } |