diff options
| author | Grygorii Strashko <grygorii.strashko@ti.com> | 2020-09-16 15:09:55 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-09-18 13:06:26 +0530 |
| commit | 52c74d3d356b60f3c53dc69e5109752347e144e8 (patch) | |
| tree | 9f0ed52a841112bf2ead509d8fd4ce057e127b87 /drivers/vlynq | |
| parent | 985d51371140d367c1b0df35c57cdc43c3d01a30 (diff) | |
| download | linux-52c74d3d356b60f3c53dc69e5109752347e144e8.tar.bz2 | |
dmaengine: ti: k3-udma-glue: fix channel enable functions
Now the K3 UDMA glue layer enable functions perform RMW operation on UDMA
RX/TX RT_CTL registers to set EN bit and enable channel, which is
incorrect, because only EN bit has to be set in those registers to enable
channel (all other bits should be cleared 0).
More over, this causes issues when bootloader leaves UDMA channel RX/TX
RT_CTL registers in incorrect state - TDOWN bit set, for example. As
result, UDMA channel will just perform teardown right after it's enabled.
Hence, fix it by writing correct values (EN=1) directly in UDMA channel
RX/TX RT_CTL registers in k3_udma_glue_enable_tx/rx_chn() functions.
Fixes: d70241913413 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20200916120955.7963-1-grygorii.strashko@ti.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/vlynq')
0 files changed, 0 insertions, 0 deletions