summaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorAndrzej Hajda <a.hajda@samsung.com>2016-02-15 15:35:24 +0100
committerTomi Valkeinen <tomi.valkeinen@ti.com>2016-02-16 15:35:12 +0200
commitf059c4b220b821f8ed7b1b12387cce86373f666e (patch)
tree6a6797f94fcf293e2b39337a3d9f12c561e70318 /drivers/video
parent206fc20598157ce15597822cf01b94377e30075b (diff)
downloadlinux-f059c4b220b821f8ed7b1b12387cce86373f666e.tar.bz2
fbdev: exynos: fix IS_ERR_VALUE usage
IS_ERR_VALUE macro should be used only with unsigned long type. For signed types comparison 'ret < 0' should be used. The patch follows conclusion from discussion on LKML [1][2]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581 Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/fbdev/exynos/exynos_mipi_dsi.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/video/fbdev/exynos/exynos_mipi_dsi.c b/drivers/video/fbdev/exynos/exynos_mipi_dsi.c
index b527fe464628..951b592794e3 100644
--- a/drivers/video/fbdev/exynos/exynos_mipi_dsi.c
+++ b/drivers/video/fbdev/exynos/exynos_mipi_dsi.c
@@ -402,12 +402,12 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
goto error;
}
- dsim->irq = platform_get_irq(pdev, 0);
- if (IS_ERR_VALUE(dsim->irq)) {
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0) {
dev_err(&pdev->dev, "failed to request dsim irq resource\n");
- ret = -EINVAL;
goto error;
}
+ dsim->irq = ret;
init_completion(&dsim_wr_comp);
init_completion(&dsim_rd_comp);