summaryrefslogtreecommitdiffstats
path: root/drivers/usb/storage
diff options
context:
space:
mode:
authorPeter Chen <peter.chen@nxp.com>2019-08-20 02:07:58 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-08-21 09:45:49 -0700
commitcbe85c88ce80fb92956a0793518d415864dcead8 (patch)
tree57009c56ce276e8381c21518a1ab9e410f7dd679 /drivers/usb/storage
parentde7b9aa633b693e77942e12f1769506efae6917b (diff)
downloadlinux-cbe85c88ce80fb92956a0793518d415864dcead8.tar.bz2
usb: chipidea: udc: don't do hardware access if gadget has stopped
After _gadget_stop_activity is executed, we can consider the hardware operation for gadget has finished, and the udc can be stopped and enter low power mode. So, any later hardware operations (from usb_ep_ops APIs or usb_gadget_ops APIs) should be considered invalid, any deinitializatons has been covered at _gadget_stop_activity. I meet this problem when I plug out usb cable from PC using mass_storage gadget, my callstack like: vbus interrupt->.vbus_session-> composite_disconnect ->pm_runtime_put_sync(&_gadget->dev), the composite_disconnect will call fsg_disable, but fsg_disable calls usb_ep_disable using async way, there are register accesses for usb_ep_disable. So sometimes, I get system hang due to visit register without clock, sometimes not. The Linux Kernel USB maintainer Alan Stern suggests this kinds of solution. See: http://marc.info/?l=linux-usb&m=138541769810983&w=2. Cc: <stable@vger.kernel.org> #v4.9+ Signed-off-by: Peter Chen <peter.chen@nxp.com> Link: https://lore.kernel.org/r/20190820020503.27080-2-peter.chen@nxp.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/storage')
0 files changed, 0 insertions, 0 deletions