diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2020-02-14 13:43:34 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-02-14 08:34:18 -0800 |
| commit | 643f7d95fe236d739aaba3b63f0627b20471d4da (patch) | |
| tree | a5880c86d84cd373451a34408a42d3d81675e10e /drivers/tty/serial/serial_core.c | |
| parent | d2403cadc1ee93b9ccf3766e1bc60e7e4d48387b (diff) | |
| download | linux-643f7d95fe236d739aaba3b63f0627b20471d4da.tar.bz2 | |
serial: core: use octal permissions on module param
Symbolic permissions 'S_IRUSR | S_IRGRP' are not preferred.
Use octal permissions '0440'. This also makes code shorter.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200214114339.53897-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/serial_core.c')
| -rw-r--r-- | drivers/tty/serial/serial_core.c | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index bb2287048108..7564bbd3061c 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -2749,19 +2749,19 @@ static ssize_t uart_get_attr_iomem_reg_shift(struct device *dev, return snprintf(buf, PAGE_SIZE, "%d\n", tmp.iomem_reg_shift); } -static DEVICE_ATTR(type, S_IRUSR | S_IRGRP, uart_get_attr_type, NULL); -static DEVICE_ATTR(line, S_IRUSR | S_IRGRP, uart_get_attr_line, NULL); -static DEVICE_ATTR(port, S_IRUSR | S_IRGRP, uart_get_attr_port, NULL); -static DEVICE_ATTR(irq, S_IRUSR | S_IRGRP, uart_get_attr_irq, NULL); -static DEVICE_ATTR(flags, S_IRUSR | S_IRGRP, uart_get_attr_flags, NULL); -static DEVICE_ATTR(xmit_fifo_size, S_IRUSR | S_IRGRP, uart_get_attr_xmit_fifo_size, NULL); -static DEVICE_ATTR(uartclk, S_IRUSR | S_IRGRP, uart_get_attr_uartclk, NULL); -static DEVICE_ATTR(close_delay, S_IRUSR | S_IRGRP, uart_get_attr_close_delay, NULL); -static DEVICE_ATTR(closing_wait, S_IRUSR | S_IRGRP, uart_get_attr_closing_wait, NULL); -static DEVICE_ATTR(custom_divisor, S_IRUSR | S_IRGRP, uart_get_attr_custom_divisor, NULL); -static DEVICE_ATTR(io_type, S_IRUSR | S_IRGRP, uart_get_attr_io_type, NULL); -static DEVICE_ATTR(iomem_base, S_IRUSR | S_IRGRP, uart_get_attr_iomem_base, NULL); -static DEVICE_ATTR(iomem_reg_shift, S_IRUSR | S_IRGRP, uart_get_attr_iomem_reg_shift, NULL); +static DEVICE_ATTR(type, 0440, uart_get_attr_type, NULL); +static DEVICE_ATTR(line, 0440, uart_get_attr_line, NULL); +static DEVICE_ATTR(port, 0440, uart_get_attr_port, NULL); +static DEVICE_ATTR(irq, 0440, uart_get_attr_irq, NULL); +static DEVICE_ATTR(flags, 0440, uart_get_attr_flags, NULL); +static DEVICE_ATTR(xmit_fifo_size, 0440, uart_get_attr_xmit_fifo_size, NULL); +static DEVICE_ATTR(uartclk, 0440, uart_get_attr_uartclk, NULL); +static DEVICE_ATTR(close_delay, 0440, uart_get_attr_close_delay, NULL); +static DEVICE_ATTR(closing_wait, 0440, uart_get_attr_closing_wait, NULL); +static DEVICE_ATTR(custom_divisor, 0440, uart_get_attr_custom_divisor, NULL); +static DEVICE_ATTR(io_type, 0440, uart_get_attr_io_type, NULL); +static DEVICE_ATTR(iomem_base, 0440, uart_get_attr_iomem_base, NULL); +static DEVICE_ATTR(iomem_reg_shift, 0440, uart_get_attr_iomem_reg_shift, NULL); static struct attribute *tty_dev_attrs[] = { &dev_attr_type.attr, |