summaryrefslogtreecommitdiffstats
path: root/drivers/staging/wilc1000
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-02-28 11:47:33 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-03-06 09:17:08 +0100
commit6cc0c259d034c6ab48f4e12f505213988e73d380 (patch)
treea9b8e119686192eb3ea06d70f3cfca2c66bf1be6 /drivers/staging/wilc1000
parent2af5f669be1446a7db56c699265bc9e4cda92577 (diff)
downloadlinux-6cc0c259d034c6ab48f4e12f505213988e73d380.tar.bz2
staging: wilc1000: add check for kmalloc allocation failure.
Add a sanity check that wid.val has been allocated, fixes a null pointer deference on stamac when calling ether_add_copy. Detected by CoverityScan, CID#1369537 ("Dereference null return value") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/wilc1000')
-rw-r--r--drivers/staging/wilc1000/host_interface.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index c2a3424c35cb..f848bb85ff1f 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1928,6 +1928,8 @@ static s32 Handle_Get_InActiveTime(struct wilc_vif *vif,
wid.type = WID_STR;
wid.size = ETH_ALEN;
wid.val = kmalloc(wid.size, GFP_KERNEL);
+ if (!wid.val)
+ return -ENOMEM;
stamac = wid.val;
ether_addr_copy(stamac, strHostIfStaInactiveT->mac);