summaryrefslogtreecommitdiffstats
path: root/drivers/staging/ncpfs
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2018-03-19 14:07:45 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-03-19 16:31:39 +0100
commit4c41aa24baa4ed338241d05494f2c595c885af8f (patch)
tree66e40138eae73dd94f4da1d9c2081992599c132e /drivers/staging/ncpfs
parentb769949981fb2f3201d42ecf66b4116861a8e998 (diff)
downloadlinux-4c41aa24baa4ed338241d05494f2c595c885af8f.tar.bz2
staging: ncpfs: memory corruption in ncp_read_kernel()
If the server is malicious then *bytes_read could be larger than the size of the "target" buffer. It would lead to memory corruption when we do the memcpy(). Reported-by: Dr Silvio Cesare of InfoSect <Silvio Cesare <silvio.cesare@gmail.com> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/ncpfs')
-rw-r--r--drivers/staging/ncpfs/ncplib_kernel.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/staging/ncpfs/ncplib_kernel.c b/drivers/staging/ncpfs/ncplib_kernel.c
index 804adfebba2f..3e047eb4cc7c 100644
--- a/drivers/staging/ncpfs/ncplib_kernel.c
+++ b/drivers/staging/ncpfs/ncplib_kernel.c
@@ -981,6 +981,10 @@ ncp_read_kernel(struct ncp_server *server, const char *file_id,
goto out;
}
*bytes_read = ncp_reply_be16(server, 0);
+ if (*bytes_read > to_read) {
+ result = -EINVAL;
+ goto out;
+ }
source = ncp_reply_data(server, 2 + (offset & 1));
memcpy(target, source, *bytes_read);