diff options
| author | Antonio Borneo <antonio.borneo@st.com> | 2020-08-10 09:12:34 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-08-10 19:46:41 +0100 |
| commit | 135dd873d3c76d812ae64c668adef3f2c59ed27f (patch) | |
| tree | 5ac6505f681a6139f4871c20fa05ff7b63e81d56 /drivers/spi/spi-stm32.c | |
| parent | ae1ba50f1e706dfd7ce402ac52c1f1f10becad68 (diff) | |
| download | linux-135dd873d3c76d812ae64c668adef3f2c59ed27f.tar.bz2 | |
spi: stm32h7: fix race condition at end of transfer
The caller of stm32_spi_transfer_one(), spi_transfer_one_message(),
is waiting for us to call spi_finalize_current_transfer() and will
eventually schedule a new transfer, if available.
We should guarantee that the spi controller is really available
before calling spi_finalize_current_transfer().
Move the call to spi_finalize_current_transfer() _after_ the call
to stm32_spi_disable().
Signed-off-by: Antonio Borneo <antonio.borneo@st.com>
Signed-off-by: Alain Volmat <alain.volmat@st.com>
Link: https://lore.kernel.org/r/1597043558-29668-2-git-send-email-alain.volmat@st.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-stm32.c')
| -rw-r--r-- | drivers/spi/spi-stm32.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 4a21feae0103..814a3ec3b8ad 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -971,8 +971,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) spin_unlock_irqrestore(&spi->lock, flags); if (end) { - spi_finalize_current_transfer(master); stm32h7_spi_disable(spi); + spi_finalize_current_transfer(master); } return IRQ_HANDLED; |