summaryrefslogtreecommitdiffstats
path: root/drivers/spi/spi-fsl-espi.c
diff options
context:
space:
mode:
authorHeiner Kallweit <hkallweit1@gmail.com>2016-08-25 06:45:55 +0200
committerMark Brown <broonie@kernel.org>2016-09-01 21:15:58 +0100
commitdbd4fefb5b7cba19e3f89c097d93ad02049e38e3 (patch)
tree09ebba0f30548d19ddc54ba4bd514965bad2ab45 /drivers/spi/spi-fsl-espi.c
parent10ed1e6d320ca01deef3bc36df91e04ecd69a60e (diff)
downloadlinux-dbd4fefb5b7cba19e3f89c097d93ad02049e38e3.tar.bz2
spi: fsl-espi: remove unneeded variable in fsl_espi_do_trans
Creating a message, adding one transfer, and then iterating over all transfers in the message doesn't make sense. We can simply use the original transfer directly. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-fsl-espi.c')
-rw-r--r--drivers/spi/spi-fsl-espi.c23
1 files changed, 8 insertions, 15 deletions
diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c
index 029017818685..f9ef50444447 100644
--- a/drivers/spi/spi-fsl-espi.c
+++ b/drivers/spi/spi-fsl-espi.c
@@ -258,11 +258,9 @@ static void fsl_espi_do_trans(struct spi_message *m,
struct spi_device *spi = m->spi;
struct mpc8xxx_spi *mspi = spi_master_get_devdata(spi->master);
struct fsl_espi_transfer *espi_trans = tr;
- struct spi_message message;
struct spi_transfer *t, *first, trans;
int status = 0;
- spi_message_init(&message);
memset(&trans, 0, sizeof(trans));
first = list_first_entry(&m->transfers, struct spi_transfer,
@@ -284,23 +282,18 @@ static void fsl_espi_do_trans(struct spi_message *m,
trans.len = espi_trans->len;
trans.tx_buf = espi_trans->tx_buf;
trans.rx_buf = espi_trans->rx_buf;
- spi_message_add_tail(&trans, &message);
- list_for_each_entry(t, &message.transfers, transfer_list) {
- if (t->bits_per_word || t->speed_hz)
- fsl_espi_setup_transfer(spi, t);
+ if (trans.bits_per_word || trans.speed_hz)
+ fsl_espi_setup_transfer(spi, &trans);
- if (t->len)
- status = fsl_espi_bufs(spi, t);
+ if (trans.len)
+ status = fsl_espi_bufs(spi, &trans);
- if (status) {
- status = -EMSGSIZE;
- break;
- }
+ if (status)
+ status = -EMSGSIZE;
- if (t->delay_usecs)
- udelay(t->delay_usecs);
- }
+ if (trans.delay_usecs)
+ udelay(trans.delay_usecs);
espi_trans->status = status;
fsl_espi_setup_transfer(spi, NULL);