summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/sd.c
diff options
context:
space:
mode:
authorweiping zhang <zhangweiping@didichuxing.com>2017-10-12 14:57:06 +0800
committerMartin K. Petersen <martin.petersen@oracle.com>2017-10-17 01:26:25 -0400
commit623401ee33e42cee64d333877892be8db02951eb (patch)
tree43ed62638bb6fd718ab410287bd70254080222fd /drivers/scsi/sd.c
parent658e9a6dc1126f21fa417cd213e1cdbff8be0ba2 (diff)
downloadlinux-623401ee33e42cee64d333877892be8db02951eb.tar.bz2
scsi: sd: change manage_start_stop to bool in sysfs interface
/sys/class/scsi_disk/0:2:0:0/manage_start_stop can be changed to 0 unexpectly by writing an invalid string. Signed-off-by: weiping zhang <zhangweiping@didichuxing.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/sd.c')
-rw-r--r--drivers/scsi/sd.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index ce9cc7afd095..37daf9a42afe 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -231,11 +231,15 @@ manage_start_stop_store(struct device *dev, struct device_attribute *attr,
{
struct scsi_disk *sdkp = to_scsi_disk(dev);
struct scsi_device *sdp = sdkp->device;
+ bool v;
if (!capable(CAP_SYS_ADMIN))
return -EACCES;
- sdp->manage_start_stop = simple_strtoul(buf, NULL, 10);
+ if (kstrtobool(buf, &v))
+ return -EINVAL;
+
+ sdp->manage_start_stop = v;
return count;
}