diff options
| author | Finn Thain <fthain@telegraphics.com.au> | 2014-11-12 16:12:19 +1100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2014-11-20 09:11:19 +0100 |
| commit | ca513fc948e66ecdd3c75cca9371762bb4c06776 (patch) | |
| tree | 354d51b6c7ffdc8390d4820a7d145d3785ed2a85 /drivers/scsi/atari_scsi.c | |
| parent | ff50f9ed0fcae6c890cc6d478814ec8cbb24feb1 (diff) | |
| download | linux-ca513fc948e66ecdd3c75cca9371762bb4c06776.tar.bz2 | |
atari_NCR5380: Introduce FLAG_TAGGED_QUEUING
The static variable setup_use_tagged_queuing is declared in mac_scsi.c,
sun3_scsi.c and atari_scsi.c and doesn't belong in the core driver.
None of the other NCR5380 drivers suffer from this layering issue which
makes merging the core drivers more difficult and will likely hinder plans
for future use of platform data to configure the driver.
Replace the static variable with a host flag. This way it can be reported
along with the other flags.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/atari_scsi.c')
| -rw-r--r-- | drivers/scsi/atari_scsi.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c index f0da0c8cbb0d..b69010604699 100644 --- a/drivers/scsi/atari_scsi.c +++ b/drivers/scsi/atari_scsi.c @@ -890,10 +890,6 @@ static int __init atari_scsi_probe(struct platform_device *pdev) } } -#ifdef SUPPORT_TAGS - if (setup_use_tagged_queuing < 0) - setup_use_tagged_queuing = 0; -#endif #ifdef REAL_DMA /* If running on a Falcon and if there's TT-Ram (i.e., more than one @@ -929,6 +925,10 @@ static int __init atari_scsi_probe(struct platform_device *pdev) host_flags |= IS_A_TT() ? 0 : FLAG_LATE_DMA_SETUP; +#ifdef SUPPORT_TAGS + host_flags |= setup_use_tagged_queuing > 0 ? FLAG_TAGGED_QUEUING : 0; +#endif + NCR5380_init(instance, host_flags); if (IS_A_TT()) { |