summaryrefslogtreecommitdiffstats
path: root/drivers/regulator
diff options
context:
space:
mode:
authorMark Brown <broonie@opensource.wolfsonmicro.com>2012-02-09 13:26:13 +0000
committerMark Brown <broonie@opensource.wolfsonmicro.com>2012-02-09 16:22:18 +0000
commit4a682922817fde4d82fed4303dc902c29d7b2e4e (patch)
treee6d67dbf05d7231af5dcaec74c341fa08d82c8b8 /drivers/regulator
parent43f674a322aa8a3404df5785f84dc1351a5d84b6 (diff)
downloadlinux-4a682922817fde4d82fed4303dc902c29d7b2e4e.tar.bz2
regulator: Complain if a voltage range is specified but can't be used
It doesn't make much sense to specify a range of voltages consumers can use if they haven't been given permission to change the voltage. Log if this happens, probably the user forgot to specify CHANGE_VOLTAGE. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by: Liam Girdwood <lrg@ti.com>
Diffstat (limited to 'drivers/regulator')
-rw-r--r--drivers/regulator/core.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index e3271daa3ab9..9a143aebb84b 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -805,6 +805,11 @@ static void print_constraints(struct regulator_dev *rdev)
count += sprintf(buf + count, "standby");
rdev_info(rdev, "%s\n", buf);
+
+ if ((constraints->min_uV != constraints->max_uV) &&
+ !(constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE))
+ rdev_warn(rdev,
+ "Voltage range but no REGULATOR_CHANGE_VOLTAGE\n");
}
static int machine_constraints_voltage(struct regulator_dev *rdev,