summaryrefslogtreecommitdiffstats
path: root/drivers/regulator
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-02-15 09:45:54 +0000
committerMark Brown <broonie@kernel.org>2019-02-19 15:27:56 +0000
commitea7b971cd64b45c6be08c02e14d30ec3c9a5b336 (patch)
tree63f03fdebfed789ebe3d2bc89a159da8427a8eca /drivers/regulator
parentafb29714ac09dfa5a72ccd8f7f9e222a500a0b31 (diff)
downloadlinux-ea7b971cd64b45c6be08c02e14d30ec3c9a5b336.tar.bz2
regulator: axp20x: remove a redundant null check on rdev
Currently rdev is dereferenced when assigning desc before rdev is null checked, this is leading to static analysis warnings. However, rdev can never be null, so the null check is redundant and can be removed. Detected by CoverityScan, CID#1476031 ("Dereference before null check") Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3") Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
-rw-r--r--drivers/regulator/axp20x-regulator.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index 98efc28f65ed..fba8f58ab769 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -372,9 +372,6 @@ static int axp20x_set_ramp_delay(struct regulator_dev *rdev, int ramp)
const int *slew_rates;
int rate_count = 0;
- if (!rdev)
- return -EINVAL;
-
desc = rdev->desc;
switch (axp20x->variant) {