diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-07-01 10:27:54 +0200 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2021-07-08 16:09:17 +0200 |
| commit | 7d6d4aaf2809f209c7d6bcab2f9ae76797051cfa (patch) | |
| tree | a008d12d1019aaf0a44e36eed3630547bf585390 /drivers/pwm/pwm-berlin.c | |
| parent | 25f70b8f3d15b8c188ecb49c6007b86f3e775c20 (diff) | |
| download | linux-7d6d4aaf2809f209c7d6bcab2f9ae76797051cfa.tar.bz2 | |
pwm: berlin: Ensure configuring period and duty_cycle isn't wrongly skipped
As the last call to berlin_pwm_apply() might have exited early if
state->enabled was false, the values for period and duty_cycle stored in
pwm->state might not have been written to hardware and it must be
ensured that they are configured before enabling the PWM.
Fixes: 30dffb42fcd4 ("pwm: berlin: Implement .apply() callback")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm/pwm-berlin.c')
| -rw-r--r-- | drivers/pwm/pwm-berlin.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/pwm/pwm-berlin.c b/drivers/pwm/pwm-berlin.c index 5537b5f6dd5d..e157273fd2f7 100644 --- a/drivers/pwm/pwm-berlin.c +++ b/drivers/pwm/pwm-berlin.c @@ -190,12 +190,9 @@ static int berlin_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, return 0; } - if (state->period != pwm->state.period || - state->duty_cycle != pwm->state.duty_cycle) { - err = berlin_pwm_config(chip, pwm, state->duty_cycle, state->period); - if (err) - return err; - } + err = berlin_pwm_config(chip, pwm, state->duty_cycle, state->period); + if (err) + return err; if (!enabled) return berlin_pwm_enable(chip, pwm); |