diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2020-04-17 22:50:52 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-04-20 11:00:27 -0700 |
commit | 135e30180ff4f654794960aba04785fe7eef2e90 (patch) | |
tree | 86252f9bf09a1d5cb79ed2f6242a80b730d93057 /drivers/ptp/ptp_kvm.c | |
parent | 0fde6e3b55a15a13f3b5aa484a79fe5298c1ed40 (diff) | |
download | linux-135e30180ff4f654794960aba04785fe7eef2e90.tar.bz2 |
net: dsa: sja1105: enable internal pull-down for RX_DV/CRS_DV/RX_CTL and RX_ER
Some boards do not have the RX_ER MII signal connected. Normally in such
situation, those pins would be grounded, but then again, some boards
left it electrically floating.
When sending traffic to those switch ports, one can see that the
N_SOFERR statistics counter is incrementing once per each packet. The
user manual states for this counter that it may count the number of
frames "that have the MII error input being asserted prior to or
up to the SOF delimiter byte". So the switch MAC is sampling an
electrically floating signal, and preventing proper traffic reception
because of that.
As a workaround, enable the internal weak pull-downs on the input pads
for the MII control signals. This way, a floating signal would be
internally tied to ground.
The logic levels of signals which _are_ externally driven should not be
bothered by this 40-50 KOhm internal resistor. So it is not an issue to
enable the internal pull-down unconditionally, irrespective of PHY
interface type (MII, RMII, RGMII, SGMII) and of board layout.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ptp/ptp_kvm.c')
0 files changed, 0 insertions, 0 deletions