summaryrefslogtreecommitdiffstats
path: root/drivers/power
diff options
context:
space:
mode:
authorKim, Milo <Milo.Kim@ti.com>2012-08-31 09:23:41 +0000
committerAnton Vorontsov <anton.vorontsov@linaro.org>2012-09-20 17:57:49 -0700
commit2a0925827be53db6252afadc79c657b14638ff4a (patch)
tree0564be968102b0df02cf09785bac21d738f90d57 /drivers/power
parent60fd57e06ed7ea13bc0bdf4cb5324d47039105ab (diff)
downloadlinux-2a0925827be53db6252afadc79c657b14638ff4a.tar.bz2
lp8727_charger: Remove unnecessary workqueue thread
LP8727 has two IRQ threads. One is the I2C HW IRQ pin, the other is for delayed interrupt processing. But this delayed processing can be handled without additional single thread by using schedule_delayed_work() with jiffies time value. Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com> Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Diffstat (limited to 'drivers/power')
-rw-r--r--drivers/power/lp8727_charger.c13
1 files changed, 1 insertions, 12 deletions
diff --git a/drivers/power/lp8727_charger.c b/drivers/power/lp8727_charger.c
index 1907b1f7953d..c33532bbb9c7 100644
--- a/drivers/power/lp8727_charger.c
+++ b/drivers/power/lp8727_charger.c
@@ -85,7 +85,6 @@ struct lp8727_chg {
struct i2c_client *client;
struct mutex xfer_lock;
struct delayed_work work;
- struct workqueue_struct *irqthread;
struct lp8727_platform_data *pdata;
struct lp8727_psy *psy;
struct lp8727_chg_param *chg_parm;
@@ -238,9 +237,7 @@ static irqreturn_t lp8727_isr_func(int irq, void *ptr)
{
struct lp8727_chg *pchg = ptr;
- queue_delayed_work(pchg->irqthread, &pchg->work,
- pchg->debounce_jiffies);
-
+ schedule_delayed_work(&pchg->work, pchg->debounce_jiffies);
return IRQ_HANDLED;
}
@@ -251,12 +248,6 @@ static int lp8727_intr_config(struct lp8727_chg *pchg)
INIT_DELAYED_WORK(&pchg->work, lp8727_delayed_func);
- pchg->irqthread = create_singlethread_workqueue("lp8727-irqthd");
- if (!pchg->irqthread) {
- dev_err(pchg->dev, "can not create thread for lp8727\n");
- return -ENOMEM;
- }
-
pchg->debounce_jiffies = msecs_to_jiffies(delay_msec);
return request_threaded_irq(pchg->client->irq,
@@ -486,8 +477,6 @@ static int __devexit lp8727_remove(struct i2c_client *cl)
struct lp8727_chg *pchg = i2c_get_clientdata(cl);
free_irq(pchg->client->irq, pchg);
- flush_workqueue(pchg->irqthread);
- destroy_workqueue(pchg->irqthread);
lp8727_unregister_psy(pchg);
return 0;
}