diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-11-18 23:04:14 +0100 |
---|---|---|
committer | Sebastian Reichel <sre@kernel.org> | 2015-12-05 02:06:49 +0100 |
commit | c4c0edfbf875a5ecb38a4aa65e2bdb87739e81d6 (patch) | |
tree | c701255e1ed8b17fdfb97e3132b19502edad713c /drivers/power | |
parent | 79fbdb66cf6ab4e26e7bcb8399ac02cd81fc5d6d (diff) | |
download | linux-c4c0edfbf875a5ecb38a4aa65e2bdb87739e81d6.tar.bz2 |
power/reset: at91-reset: add missing of_node_put
for_each_matching_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.
A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):
// <smpl>
@@
expression e,e1;
local idexpression np;
@@
for_each_matching_node(np, e1) {
... when != of_node_put(np)
when != e = np
(
return np;
|
+ of_node_put(np);
? return ...;
)
...
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers/power')
-rw-r--r-- | drivers/power/reset/at91-reset.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c index 3f6b5dd7c3d4..1b5d450586d1 100644 --- a/drivers/power/reset/at91-reset.c +++ b/drivers/power/reset/at91-reset.c @@ -198,6 +198,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) at91_ramc_base[idx] = of_iomap(np, 0); if (!at91_ramc_base[idx]) { dev_err(&pdev->dev, "Could not map ram controller address\n"); + of_node_put(np); return -ENODEV; } idx++; |