summaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl/qcom
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-21 16:33:41 +0100
committerLinus Walleij <linus.walleij@linaro.org>2015-12-26 22:28:38 +0100
commit464231fb1fb1360399a2eb11479c47e39facb030 (patch)
tree7d3677b232773c02019af3b9de7d90df8cc3abca /drivers/pinctrl/qcom
parent59663a4cc5270f618e2b99d719b492bb1020deb8 (diff)
downloadlinux-464231fb1fb1360399a2eb11479c47e39facb030.tar.bz2
pinctrl: ssbi-gpio: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Also, this code was double-inverting a bool. That makes no sense whatsoever, so I removed the double-invert. Cc: Björn Andersson <bjorn.andersson@sonymobile.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/qcom')
-rw-r--r--drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
index 7bea0df06fb1..394ca34bec4a 100644
--- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
@@ -487,10 +487,10 @@ static int pm8xxx_gpio_get(struct gpio_chip *chip, unsigned offset)
} else {
ret = irq_get_irqchip_state(pin->irq, IRQCHIP_STATE_LINE_LEVEL, &state);
if (!ret)
- ret = !!state;
+ ret = state;
}
- return ret;
+ return !!ret;
}
static void pm8xxx_gpio_set(struct gpio_chip *chip, unsigned offset, int value)