summaryrefslogtreecommitdiffstats
path: root/drivers/pci/rom.c
diff options
context:
space:
mode:
authorAlex Deucher <alexdeucher@gmail.com>2017-11-27 12:21:10 -0500
committerBjorn Helgaas <bhelgaas@google.com>2017-12-18 23:07:43 -0600
commit116a6063cac3107d5abfe7bd14fc01a19271b14a (patch)
treeb23e50db21a363c5319e6cd47fe9a90df53f2a45 /drivers/pci/rom.c
parent7153884c088a9500f9379aeec877f3d4d4ec4fba (diff)
downloadlinux-116a6063cac3107d5abfe7bd14fc01a19271b14a.tar.bz2
PCI: Use dev_info() rather than dev_err() for ROM validation
On AMD GPUs, we use several mechanisms to fetch the VBIOS ROM depending on the platform. We try to read the ROM via the ROM BAR and fall back to other methods in some cases. This leads to spurious error messages from the PCI ROM code which are harmless in our case. This leads to bugs being filed, etc. Change these to dev_info() rather than dev_err() to avoid that. Link: https://bugzilla.kernel.org/show_bug.cgi?id=198077 Link: https://bugzilla.redhat.com/show_bug.cgi?id=1462438 Link: https://bugs.freedesktop.org/show_bug.cgi?id=98798 Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Christian König <christian.koenig@amd.com
Diffstat (limited to 'drivers/pci/rom.c')
-rw-r--r--drivers/pci/rom.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
index 1f5e6af96c83..68ab7c17955a 100644
--- a/drivers/pci/rom.c
+++ b/drivers/pci/rom.c
@@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size)
void __iomem *pds;
/* Standard PCI ROMs start out with these bytes 55 AA */
if (readw(image) != 0xAA55) {
- dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
+ dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
readw(image));
break;
}
/* get the PCI data structure and check its "PCIR" signature */
pds = image + readw(image + 24);
if (readl(pds) != 0x52494350) {
- dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
+ dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
readl(pds));
break;
}