diff options
| author | Matthew Garrett <mjg@redhat.com> | 2010-06-22 17:03:03 -0400 |
|---|---|---|
| committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2010-07-30 09:29:34 -0700 |
| commit | ea5f9fc5899660dd26c1ccf3fab183bd041140ee (patch) | |
| tree | b0d0517ee4064cfb587651b195ee5d2be864a8cc /drivers/pci/msi.c | |
| parent | 8cc2bfd87fdd2f4a31f39c86f59df4b4be2c0adc (diff) | |
| download | linux-ea5f9fc5899660dd26c1ccf3fab183bd041140ee.tar.bz2 | |
PCI: Default PCIe ASPM control to on and require !EMBEDDED to disable
The CONFIG_PCIEASPM option is confusing and potentially dangerous. ASPM is
a hardware mediated feature rather than one under direct OS control, and
even if the config option is disabled the system firmware may have turned
on ASPM on various bits of hardware. This can cause problems later -
various hardware that claims to support ASPM does a poor job of it and may
hang or cause other difficulties. The kernel is able to recognise this in
many cases and disable the ASPM functionality, but only if CONFIG_PCIEASPM
is enabled.
Given that in its default configuration this option will either leave the
hardware as it was originally or disable hardware functionality that may
cause problems, it should by default y. The only reason to disable it
ought to be to reduce code size, so make it dependent on CONFIG_EMBEDDED.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Cc: lrodriguez@atheros.com
Cc: maximlevitsky@gmail.com
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/pci/msi.c')
0 files changed, 0 insertions, 0 deletions