summaryrefslogtreecommitdiffstats
path: root/drivers/pci/host/pcie-iproc.c
diff options
context:
space:
mode:
authorRay Jui <ray.jui@broadcom.com>2016-11-21 17:48:30 -0800
committerBjorn Helgaas <bhelgaas@google.com>2016-11-23 17:15:31 -0600
commitfeacdb4a35920235a0daf42d6f5701a74c4708b5 (patch)
tree743e8b4b6b276f7adee6e66355959a3bb08b0a51 /drivers/pci/host/pcie-iproc.c
parentc7c44527b364bce2858bc1c8b630371fea153b56 (diff)
downloadlinux-feacdb4a35920235a0daf42d6f5701a74c4708b5.tar.bz2
PCI: iproc: Fix incorrect MSI address alignment
In the code to handle PAXB v2 based MSI steering, the logic aligns the MSI register address to the size of supported inbound mapping range. This is incorrect since it rounds "up" the starting address to the next aligned address, but what we want is the starting address to be rounded "down" to the aligned address. This patch fixes the issue and allows MSI writes to be properly steered to the GIC. Fixes: 4b073155fbd3 ("PCI: iproc: Add support for the next-gen PAXB controller") Signed-off-by: Ray Jui <ray.jui@broadcom.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/host/pcie-iproc.c')
-rw-r--r--drivers/pci/host/pcie-iproc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c
index 3d02ad261761..cd513342b913 100644
--- a/drivers/pci/host/pcie-iproc.c
+++ b/drivers/pci/host/pcie-iproc.c
@@ -1020,7 +1020,7 @@ static int iproc_pcie_paxb_v2_msi_steer(struct iproc_pcie *pcie, u64 msi_addr)
memset(&range, 0, sizeof(range));
range.size = SZ_32K;
- range.pci_addr = range.cpu_addr = ALIGN(msi_addr, range.size);
+ range.pci_addr = range.cpu_addr = msi_addr & ~(range.size - 1);
ret = iproc_pcie_setup_ib(pcie, &range, IPROC_PCIE_IB_MAP_IO);
return ret;