diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-06-04 12:04:12 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-06-12 16:58:33 -0700 |
commit | 0c6d5c89a112620d2166b8d042d3d69bb42b626c (patch) | |
tree | 7256aae1b6ba79b7f040bfada4bec7c2e1a673f0 /drivers/parport | |
parent | a14ef24b07b63669d58c16d836ddbadcce3e7ad0 (diff) | |
download | linux-0c6d5c89a112620d2166b8d042d3d69bb42b626c.tar.bz2 |
w1: use correct lock on error in w1_seq_show()
I noticed there was a problem here because Smatch complained:
drivers/w1/slaves/w1_therm.c:416 w1_seq_show() warn:
inconsistent returns 'mutex:&sl->master->mutex'.
Locked on: line 416
Unlocked on: line 413
The problem is that we lock ->mutex but we unlock ->bus_mutex on error.
David Fries says that ->bus_mutex is correct and ->mutex is incorrect.
Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/parport')
0 files changed, 0 insertions, 0 deletions