diff options
| author | Johan Hovold <johan@kernel.org> | 2016-11-16 15:20:36 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-11-17 12:05:04 -0500 |
| commit | 48c1699d5335bc045b50989a06b1c526b17a25ff (patch) | |
| tree | 5075ac7364141e1e8d853d9b8b9219917aa56b07 /drivers/of | |
| parent | cfc44a4d147ea605d66ccb917cc24467d15ff867 (diff) | |
| download | linux-48c1699d5335bc045b50989a06b1c526b17a25ff.tar.bz2 | |
of_mdio: fix node leak in of_phy_register_fixed_link error path
Make sure to drop the of_node reference also on failure to parse the
speed property in of_phy_register_fixed_link().
Fixes: 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/of')
| -rw-r--r-- | drivers/of/of_mdio.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index b470f7e3521d..8f4648383fb2 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -456,8 +456,11 @@ int of_phy_register_fixed_link(struct device_node *np) status.link = 1; status.duplex = of_property_read_bool(fixed_link_node, "full-duplex"); - if (of_property_read_u32(fixed_link_node, "speed", &status.speed)) + if (of_property_read_u32(fixed_link_node, "speed", + &status.speed)) { + of_node_put(fixed_link_node); return -EINVAL; + } status.pause = of_property_read_bool(fixed_link_node, "pause"); status.asym_pause = of_property_read_bool(fixed_link_node, "asym-pause"); |