summaryrefslogtreecommitdiffstats
path: root/drivers/nvme
diff options
context:
space:
mode:
authorJens Axboe <axboe@kernel.dk>2018-05-17 18:31:48 +0200
committerKeith Busch <keith.busch@intel.com>2018-05-18 14:41:35 -0600
commitf9dde187fa921c12a8680089a77595b866e65455 (patch)
treea40e74d40bacb150655d70035c490123fb94d1b9 /drivers/nvme
parent750dde4472e48eadf28221b7eb02d493db1bcfd0 (diff)
downloadlinux-f9dde187fa921c12a8680089a77595b866e65455.tar.bz2
nvme-pci: remove cq check after submission
We always check the completion queue after submitting, but in my testing this isn't a win even on DRAM/xpoint devices. In some cases it's actually worse. Kill it. Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Keith Busch <keith.busch@intel.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
-rw-r--r--drivers/nvme/host/pci.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index cf36dd39f2a5..577570d3e1f4 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -69,7 +69,6 @@ MODULE_PARM_DESC(io_queue_depth, "set io queue depth, should >= 2");
struct nvme_dev;
struct nvme_queue;
-static void nvme_process_cq(struct nvme_queue *nvmeq);
static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown);
/*
@@ -896,7 +895,6 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
goto out_cleanup_iod;
}
__nvme_submit_cmd(nvmeq, &cmnd);
- nvme_process_cq(nvmeq);
spin_unlock_irq(&nvmeq->q_lock);
return BLK_STS_OK;
out_cleanup_iod: