diff options
| author | Bart Van Assche <bvanassche@acm.org> | 2018-10-08 14:28:41 -0700 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2018-10-17 08:58:25 +0200 |
| commit | bb2a1d4e804aa41eef0003a192a674f844dbca23 (patch) | |
| tree | fdfcb948583ac36643ff698f35d019189af742a6 /drivers/nvme | |
| parent | eb090c4c948ccc7a051451261cf1426edf83f3eb (diff) | |
| download | linux-bb2a1d4e804aa41eef0003a192a674f844dbca23.tar.bz2 | |
nvme-core: rework a NQN copying operation
Although it is easy to see that the code in nvme_init_subnqn() guarantees that
the subsys->nqn string is '\0'-terminated, apparently Coverity is not smart
enough to see this. Make it easier for Coverity to analyze this code by changing
the strncpy() call into a strlcpy() call. This patch does not change the
behavior of the code but fixes Coveritiy ID 1423720.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 63932dea74a1..8cecb36b5af1 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2076,7 +2076,7 @@ static void nvme_init_subnqn(struct nvme_subsystem *subsys, struct nvme_ctrl *ct nqnlen = strnlen(id->subnqn, NVMF_NQN_SIZE); if (nqnlen > 0 && nqnlen < NVMF_NQN_SIZE) { - strncpy(subsys->subnqn, id->subnqn, NVMF_NQN_SIZE); + strlcpy(subsys->subnqn, id->subnqn, NVMF_NQN_SIZE); return; } |