diff options
author | Max Gurtovoy <mgurtovoy@nvidia.com> | 2021-02-17 17:19:40 +0000 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2021-03-05 13:41:03 +0100 |
commit | d9f273b7585c380d7a10d4b3187ddc2d37f2740b (patch) | |
tree | 998d7f00c98c8e32455368f243f5ccef5ab577bf /drivers/nvme/target/core.c | |
parent | 32feb6de47242e54692eceab52cfae8616aa0518 (diff) | |
download | linux-d9f273b7585c380d7a10d4b3187ddc2d37f2740b.tar.bz2 |
nvmet: model_number must be immutable once set
In case we have already established connection to nvmf target, it
shouldn't be allowed to change the model_number. E.g. if someone will
identify ctrl and get model_number of "my_model" later on will change
the model_numbel via configfs to "my_new_model" this will break the NVMe
specification for "Get Log Page – Persistent Event Log" that refers to
Model Number as: "This field contains the same value as reported in the
Model Number field of the Identify Controller data structure, bytes
63:24."
Although it doesn't mentioned explicitly that this field can't be
changed, we can assume it.
So allow setting this field only once: using configfs or in the first
identify ctrl operation.
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme/target/core.c')
-rw-r--r-- | drivers/nvme/target/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 67bbf0e3b507..be6fcdaf51a7 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -1532,7 +1532,7 @@ static void nvmet_subsys_free(struct kref *ref) nvmet_passthru_subsys_free(subsys); kfree(subsys->subsysnqn); - kfree_rcu(subsys->model, rcuhead); + kfree(subsys->model_number); kfree(subsys); } |