diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2017-09-26 13:07:06 -0700 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2017-09-28 09:13:06 -0700 |
| commit | 26417ae4fc6108f8db436f24108b08f68bdc520e (patch) | |
| tree | bbfe1892d5a968c15e55571535f1ed82cb08766a /drivers/nvdimm | |
| parent | c1fb3542074fd0c4d901d778bd52455111e4eb6f (diff) | |
| download | linux-26417ae4fc6108f8db436f24108b08f68bdc520e.tar.bz2 | |
libnvdimm, pfn: make 'resource' attribute only readable by root
For the same reason that /proc/iomem returns 0's for non-root readers
and acpi tables are root-only, make the 'resource' attribute for pfn
devices only readable by root. Otherwise we disclose physical address
information.
Fixes: f6ed58c70d14 ("libnvdimm, pfn: 'resource'-address and 'size'...")
Cc: <stable@vger.kernel.org>
Reported-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/nvdimm')
| -rw-r--r-- | drivers/nvdimm/pfn_devs.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c index 9576c444f0ab..65cc171c721d 100644 --- a/drivers/nvdimm/pfn_devs.c +++ b/drivers/nvdimm/pfn_devs.c @@ -282,8 +282,16 @@ static struct attribute *nd_pfn_attributes[] = { NULL, }; +static umode_t pfn_visible(struct kobject *kobj, struct attribute *a, int n) +{ + if (a == &dev_attr_resource.attr) + return 0400; + return a->mode; +} + struct attribute_group nd_pfn_attribute_group = { .attrs = nd_pfn_attributes, + .is_visible = pfn_visible, }; static const struct attribute_group *nd_pfn_attribute_groups[] = { |