diff options
| author | Vishal Verma <vishal.l.verma@intel.com> | 2017-06-29 16:59:11 -0600 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2017-06-29 18:24:28 -0700 |
| commit | c13c43d54f2c6a3be1c675766778ac1ad8dfbfcc (patch) | |
| tree | 2152613ee27b6df5f6d077e8845f714ebf8ba9b1 /drivers/nvdimm/btt.c | |
| parent | d5d51fece79eafcdbc69d1836c28a3c9c7c8e862 (diff) | |
| download | linux-c13c43d54f2c6a3be1c675766778ac1ad8dfbfcc.tar.bz2 | |
libnvdimm, btt: fix btt_rw_page not returning errors
btt_rw_page was not propagating errors frm btt_do_bvec, resulting in any
IO errors via the rw_page path going unnoticed. the pmem driver recently
fixed this in e10624f pmem: fail io-requests to known bad blocks
but same problem in BTT went neglected.
Fixes: 5212e11fde4d ("nd_btt: atomic sector updates")
Cc: <stable@vger.kernel.org>
Cc: Toshi Kani <toshi.kani@hpe.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/nvdimm/btt.c')
| -rw-r--r-- | drivers/nvdimm/btt.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 7ca11df80ae8..4e56e720288d 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -1248,10 +1248,13 @@ static int btt_rw_page(struct block_device *bdev, sector_t sector, struct page *page, bool is_write) { struct btt *btt = bdev->bd_disk->private_data; + int rc; - btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector); - page_endio(page, is_write, 0); - return 0; + rc = btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector); + if (rc == 0) + page_endio(page, is_write, 0); + + return rc; } |