diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2021-05-19 14:16:27 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-05-19 13:13:26 -0700 |
| commit | 20e76d3d044d936998617f8acd7e77bebd9ca703 (patch) | |
| tree | a2d052f79afa4ec1feac631eb4b7d2022c6804c0 /drivers/net | |
| parent | 05ff8435e50569a0a6b95e5ceaea43696e8827ab (diff) | |
| download | linux-20e76d3d044d936998617f8acd7e77bebd9ca703.tar.bz2 | |
net: ethernet: ixp4xx: Fix return value check in ixp4xx_eth_probe()
In case of error, the function mdiobus_get_phy() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/xscale/ixp4xx_eth.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c index cb89323855d8..1ecceeb9700d 100644 --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c @@ -1531,8 +1531,8 @@ static int ixp4xx_eth_probe(struct platform_device *pdev) phydev = of_phy_get_and_connect(ndev, np, ixp4xx_adjust_link); } else { phydev = mdiobus_get_phy(mdio_bus, plat->phy); - if (IS_ERR(phydev)) { - err = PTR_ERR(phydev); + if (!phydev) { + err = -ENODEV; dev_err(dev, "could not connect phydev (%d)\n", err); goto err_free_mem; } |