diff options
| author | Alex Elder <elder@linaro.org> | 2022-05-26 10:23:13 -0500 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-05-27 18:29:50 -0700 |
| commit | 155c0c90bca918de6e4327275dfc1d97fd604115 (patch) | |
| tree | cc4fb33d98c5150215798edddd486b745abc389e /drivers/net | |
| parent | 4dc160a52da1330d54d561f9dac8a9e0ef333895 (diff) | |
| download | linux-155c0c90bca918de6e4327275dfc1d97fd604115.tar.bz2 | |
net: ipa: fix page free in ipa_endpoint_trans_release()
Currently the (possibly compound) page used for receive buffers are
freed using __free_pages(). But according to this comment above the
definition of that function, that's wrong:
If you want to use the page's reference count to decide when
to free the allocation, you should allocate a compound page,
and use put_page() instead of __free_pages().
Convert the call to __free_pages() in ipa_endpoint_trans_release()
to use put_page() instead.
Fixes: ed23f02680caa ("net: ipa: define per-endpoint receive buffer size")
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ipa/ipa_endpoint.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 385aa63ab4bb..e92aa9447f6e 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -1418,11 +1418,8 @@ void ipa_endpoint_trans_release(struct ipa_endpoint *endpoint, } else { struct page *page = trans->data; - if (page) { - u32 buffer_size = endpoint->config.rx.buffer_size; - - __free_pages(page, get_order(buffer_size)); - } + if (page) + put_page(page); } } |