summaryrefslogtreecommitdiffstats
path: root/drivers/net/xen-netback
diff options
context:
space:
mode:
authorJuergen Gross <jgross@suse.com>2019-10-18 09:45:49 +0200
committerDavid S. Miller <davem@davemloft.net>2019-10-19 11:43:29 -0700
commit3d5c1a037d37392a6859afbde49be5ba6a70a6b3 (patch)
tree04bcb32899722e30dab4be6a65cd6ed1e6430909 /drivers/net/xen-netback
parent580a05f9d4ada3bfb689140d0efec1efdb8a48da (diff)
downloadlinux-3d5c1a037d37392a6859afbde49be5ba6a70a6b3.tar.bz2
xen/netback: fix error path of xenvif_connect_data()
xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get(). Remove the superfluous module_put(). Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down") Cc: <stable@vger.kernel.org> # 3.12 Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Paul Durrant <paul@xen.org> Reviewed-by: Wei Liu <wei.liu@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/xen-netback')
-rw-r--r--drivers/net/xen-netback/interface.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 240f762b3749..103ed00775eb 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -719,7 +719,6 @@ err_unmap:
xenvif_unmap_frontend_data_rings(queue);
netif_napi_del(&queue->napi);
err:
- module_put(THIS_MODULE);
return err;
}