summaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/ti
diff options
context:
space:
mode:
authorTom Rix <trix@redhat.com>2020-08-02 09:18:04 -0700
committerKalle Valo <kvalo@codeaurora.org>2020-08-18 15:49:28 +0300
commit9c9f015bc9f8839831c7ba0a6d731a3853c464e2 (patch)
tree9b6da830694c6fc91395d497c9f07c3310c2c5db /drivers/net/wireless/ti
parent838933ca5b9cb5af7f17c41524d927b7a580b0e0 (diff)
downloadlinux-9c9f015bc9f8839831c7ba0a6d731a3853c464e2.tar.bz2
brcmfmac: check ndev pointer
Clang static analysis reports this error brcmfmac/core.c:490:4: warning: Dereference of null pointer (*ifp)->ndev->stats.rx_errors++; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In this block of code if (ret || !(*ifp) || !(*ifp)->ndev) { if (ret != -ENODATA && *ifp) (*ifp)->ndev->stats.rx_errors++; brcmu_pkt_buf_free_skb(skb); return -ENODATA; } (*ifp)->ndev being NULL is caught as an error But then it is used to report the error. So add a check before using it. Fixes: 91b632803ee4 ("brcmfmac: Use net_device_stats from struct net_device") Signed-off-by: Tom Rix <trix@redhat.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200802161804.6126-1-trix@redhat.com
Diffstat (limited to 'drivers/net/wireless/ti')
0 files changed, 0 insertions, 0 deletions