diff options
author | Wen Yang <wen.yang99@zte.com.cn> | 2019-01-03 01:09:53 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-01-04 12:50:43 -0800 |
commit | 8d68100ab4ad92560a16a68b72e068613ac4d573 (patch) | |
tree | 136f714932c2a9ff615fcf16745a4072b402402a /drivers/net/wan/hdlc_raw.c | |
parent | 36352991835ce99e46b4441dd0eb6980f9a83e8f (diff) | |
download | linux-8d68100ab4ad92560a16a68b72e068613ac4d573.tar.bz2 |
soc/fsl/qe: fix err handling of ucc_of_parse_tdm
Currently there are some issues with the ucc_of_parse_tdm function:
1, a possible null pointer dereference in ucc_of_parse_tdm,
detected by the semantic patch deref_null.cocci,
with the following warning:
drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is NULL but dereferenced.
2, dev gets modified, so in any case that devm_iounmap() will fail
even when the new pdev is valid, because the iomap was done with a
different pdev.
3, there is no driver bind with the "fsl,t1040-qe-si" or
"fsl,t1040-qe-siram" device. So allocating resources using devm_*()
with these devices won't provide a cleanup path for these resources
when the caller fails.
This patch fixes them.
Suggested-by: Li Yang <leoyang.li@nxp.com>
Suggested-by: Christophe LEROY <christophe.leroy@c-s.fr>
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Reviewed-by: Peng Hao <peng.hao2@zte.com.cn>
CC: Julia Lawall <julia.lawall@lip6.fr>
CC: Zhao Qiang <qiang.zhao@nxp.com>
CC: David S. Miller <davem@davemloft.net>
CC: netdev@vger.kernel.org
CC: linuxppc-dev@lists.ozlabs.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wan/hdlc_raw.c')
0 files changed, 0 insertions, 0 deletions