summaryrefslogtreecommitdiffstats
path: root/drivers/net/usb/rtl8150.c
diff options
context:
space:
mode:
authorAlexander Sverdlin <alexander.sverdlin@nsn.com>2018-07-13 17:31:50 +0200
committerDavid S. Miller <davem@davemloft.net>2018-07-18 13:13:07 +0900
commit4aac0b43474d18f6160302a3caa147d77fa3baa1 (patch)
tree42be4e5cc968c3f298c2bb9822bea106c3928d67 /drivers/net/usb/rtl8150.c
parent1992d99882afda6dc17f9d49c06150856a91282f (diff)
downloadlinux-4aac0b43474d18f6160302a3caa147d77fa3baa1.tar.bz2
octeon_mgmt: Fix MIX registers configuration on MTU setup
octeon_mgmt driver doesn't drop RX frames that are 1-4 bytes bigger than MTU set for the corresponding interface. The problem is in the AGL_GMX_RX0/1_FRM_MAX register setting, which should not account for VLAN tagging. According to Octeon HW manual: "For tagged frames, MAX increases by four bytes for each VLAN found up to a maximum of two VLANs, or MAX + 8 bytes." OCTEON_FRAME_HEADER_LEN "define" is fine for ring buffer management, but should not be used for AGL_GMX_RX0/1_FRM_MAX. The problem could be easily reproduced using "ping" command. If affected system has default MTU 1500, other host (having MTU >= 1504) can successfully "ping" the affected system with payload size 1473-1476, resulting in IP packets of size 1501-1504 accepted by the mgmt driver. Fixed system still accepts IP packets of 1500 bytes even with VLAN tagging, because the limits are lifted in HW as expected, for every VLAN tag. Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/rtl8150.c')
0 files changed, 0 insertions, 0 deletions