diff options
| author | Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-14 13:03:38 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-08-18 13:01:54 -0700 |
| commit | 1eca92eef18719027d394bf1a2d276f43e7cf886 (patch) | |
| tree | 6f73e6f38e3746cb8b3a70f6d98c78f4d097ac65 /drivers/net/usb/cx82310_eth.c | |
| parent | 4a4d2d372fb9b9229327e2ed01d5d9572eddf4de (diff) | |
| download | linux-1eca92eef18719027d394bf1a2d276f43e7cf886.tar.bz2 | |
cx82310_eth: fix a memory leak bug
In cx82310_bind(), 'dev->partial_data' is allocated through kmalloc().
Then, the execution waits for the firmware to become ready. If the firmware
is not ready in time, the execution is terminated. However, the allocated
'dev->partial_data' is not deallocated on this path, leading to a memory
leak bug. To fix this issue, free 'dev->partial_data' before returning the
error.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/cx82310_eth.c')
| -rw-r--r-- | drivers/net/usb/cx82310_eth.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/usb/cx82310_eth.c b/drivers/net/usb/cx82310_eth.c index 5519248a791e..32b08b18e120 100644 --- a/drivers/net/usb/cx82310_eth.c +++ b/drivers/net/usb/cx82310_eth.c @@ -163,7 +163,8 @@ static int cx82310_bind(struct usbnet *dev, struct usb_interface *intf) } if (!timeout) { dev_err(&udev->dev, "firmware not ready in time\n"); - return -ETIMEDOUT; + ret = -ETIMEDOUT; + goto err; } /* enable ethernet mode (?) */ |