summaryrefslogtreecommitdiffstats
path: root/drivers/net/ppp
diff options
context:
space:
mode:
authorstephen hemminger <stephen@networkplumber.org>2013-08-10 15:22:58 -0700
committerDavid S. Miller <davem@davemloft.net>2013-08-13 15:10:22 -0700
commitebd8b934e23f45ad3fc8a5a28bc5a96741a6a106 (patch)
treefc30abaada405342996d5f96e343bc499454253d /drivers/net/ppp
parent072017b41e49e2a8e8a4e0258837a614bb5daa8d (diff)
downloadlinux-ebd8b934e23f45ad3fc8a5a28bc5a96741a6a106.tar.bz2
pptp: fix byte order warnings
Pptp driver has lots of byte order warnings from sparse. This was because the on-the-wire header is in network byte order (obviously) but the definition did not reflect that. Also, the address structure to user space actually put the call id in host order. Rather than break ABI compatibility, just acknowledge the existing design. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ppp')
-rw-r--r--drivers/net/ppp/pptp.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
index 9785a3ac02b3..6fa5ae00039f 100644
--- a/drivers/net/ppp/pptp.c
+++ b/drivers/net/ppp/pptp.c
@@ -83,11 +83,11 @@ static const struct proto_ops pptp_ops;
struct pptp_gre_header {
u8 flags;
u8 ver;
- u16 protocol;
- u16 payload_len;
- u16 call_id;
- u32 seq;
- u32 ack;
+ __be16 protocol;
+ __be16 payload_len;
+ __be16 call_id;
+ __be32 seq;
+ __be32 ack;
} __packed;
static struct pppox_sock *lookup_chan(u16 call_id, __be32 s_addr)