summaryrefslogtreecommitdiffstats
path: root/drivers/net/mii.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-11-08 14:31:38 +0100
committerDavid S. Miller <davem@davemloft.net>2016-11-09 20:26:58 -0500
commitdc0b2c9cb47a2176e1f341bfdc770745d24e072c (patch)
tree12f2d9174981021fafa834aac5fe4176dfe4e3c7 /drivers/net/mii.c
parent6c27f99d35f4d14b7fc5e50ae1f822d7cca6a5af (diff)
downloadlinux-dc0b2c9cb47a2176e1f341bfdc770745d24e072c.tar.bz2
net: mii: report 0 for unknown lp_advertising
The newly introduced mii_ethtool_get_link_ksettings function sets lp_advertising to an uninitialized value when BMCR_ANENABLE is not set: drivers/net/mii.c: In function 'mii_ethtool_get_link_ksettings': drivers/net/mii.c:224:2: error: 'lp_advertising' may be used uninitialized in this function [-Werror=maybe-uninitialized] As documented in include/uapi/linux/ethtool.h, the value is expected to be zero when we don't know it, so let's initialize it to that. Fixes: bc8ee596afe8 ("net: mii: add generic function to support ksetting support") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/mii.c')
-rw-r--r--drivers/net/mii.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/mii.c b/drivers/net/mii.c
index 0443546fc427..6d953c53eed6 100644
--- a/drivers/net/mii.c
+++ b/drivers/net/mii.c
@@ -213,6 +213,8 @@ int mii_ethtool_get_link_ksettings(struct mii_if_info *mii,
SPEED_100 : SPEED_10));
cmd->base.duplex = (bmcr & BMCR_FULLDPLX) ?
DUPLEX_FULL : DUPLEX_HALF;
+
+ lp_advertising = 0;
}
mii->full_duplex = cmd->base.duplex;