diff options
| author | David S. Miller <davem@davemloft.net> | 2012-04-01 20:23:06 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-04-02 04:33:43 -0400 |
| commit | ead9a76ceec34df18dc84cb22053253bd5564376 (patch) | |
| tree | 387df8997ce0d054e6ed1c7c9606d7dda3c91513 /drivers/net/macvlan.c | |
| parent | 1a106de6e6543e7d44dbe1bc5f37a8964607dfa6 (diff) | |
| download | linux-ead9a76ceec34df18dc84cb22053253bd5564376.tar.bz2 | |
macvlan: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/macvlan.c')
| -rw-r--r-- | drivers/net/macvlan.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index f975afdc315c..b17fc9007099 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -773,7 +773,8 @@ static int macvlan_fill_info(struct sk_buff *skb, { struct macvlan_dev *vlan = netdev_priv(dev); - NLA_PUT_U32(skb, IFLA_MACVLAN_MODE, vlan->mode); + if (nla_put_u32(skb, IFLA_MACVLAN_MODE, vlan->mode)) + goto nla_put_failure; return 0; nla_put_failure: |