summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/tundra
diff options
context:
space:
mode:
authorNithin Sujir <nsujir@broadcom.com>2014-02-06 14:13:05 -0800
committerDavid S. Miller <davem@davemloft.net>2014-02-06 20:05:36 -0800
commitc6993dfd7db9b0c6b7ca7503a56fda9236a4710f (patch)
treedfcd1e419db321faf79ad05e3feb56901db2cbba /drivers/net/ethernet/tundra
parentc6e27f2f3cf2631aae6f1f6fae1a7ab083fdb024 (diff)
downloadlinux-c6993dfd7db9b0c6b7ca7503a56fda9236a4710f.tar.bz2
tg3: Fix deadlock in tg3_change_mtu()
Quoting David Vrabel - "5780 cards cannot have jumbo frames and TSO enabled together. When jumbo frames are enabled by setting the MTU, the TSO feature must be cleared. This is done indirectly by calling netdev_update_features() which will call tg3_fix_features() to actually clear the flags. netdev_update_features() will also trigger a new netlink message for the feature change event which will result in a call to tg3_get_stats64() which deadlocks on the tg3 lock." tg3_set_mtu() does not need to be under the tg3 lock since converting the flags to use set_bit(). Move it out to after tg3_netif_stop(). Reported-by: David Vrabel <david.vrabel@citrix.com> Tested-by: David Vrabel <david.vrabel@citrix.com> Signed-off-by: Michael Chan <mchan@broadcom.com> Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/tundra')
0 files changed, 0 insertions, 0 deletions