diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-07-02 07:09:32 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-03 23:21:07 +0900 |
| commit | c18a9c096683dd30300686ffc755443816893968 (patch) | |
| tree | 743b298f57a1343169139eb1dfcd8808037ad075 /drivers/net/ethernet/stmicro | |
| parent | 00f553660a7f524a3b913cb5cf6c5f33f9638f09 (diff) | |
| download | linux-c18a9c096683dd30300686ffc755443816893968.tar.bz2 | |
net: stmmac_tc: use 64-bit arithmetic instead of 32-bit
Add suffix UL to constant 1024 in order to give the compiler complete
information about the proper arithmetic to use. Notice that this
constant is used in a context that expects an expression of type
u64 (64 bits, unsigned) and following expressions are currently
being evaluated using 32-bit arithmetic:
qopt->idleslope * 1024 * ptr
qopt->hicredit * 1024 * 8
qopt->locredit * 1024 * 8
Addresses-Coverity-ID: 1470246 ("Unintentional integer overflow")
Addresses-Coverity-ID: 1470248 ("Unintentional integer overflow")
Addresses-Coverity-ID: 1470249 ("Unintentional integer overflow")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jose Abreu <joabreu@synopsys.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/stmicro')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c index 0b0fca0200b2..8fedc288d138 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -321,7 +321,7 @@ static int tc_setup_cbs(struct stmmac_priv *priv, speed_div = (priv->speed == SPEED_100) ? 100000 : 1000000; /* Final adjustments for HW */ - value = qopt->idleslope * 1024 * ptr; + value = qopt->idleslope * 1024UL * ptr; do_div(value, speed_div); priv->plat->tx_queues_cfg[queue].idle_slope = value & GENMASK(31, 0); @@ -329,10 +329,10 @@ static int tc_setup_cbs(struct stmmac_priv *priv, do_div(value, speed_div); priv->plat->tx_queues_cfg[queue].send_slope = value & GENMASK(31, 0); - value = qopt->hicredit * 1024 * 8; + value = qopt->hicredit * 1024UL * 8; priv->plat->tx_queues_cfg[queue].high_credit = value & GENMASK(31, 0); - value = qopt->locredit * 1024 * 8; + value = qopt->locredit * 1024UL * 8; priv->plat->tx_queues_cfg[queue].low_credit = value & GENMASK(31, 0); ret = stmmac_config_cbs(priv, priv->hw, |