summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/socionext
diff options
context:
space:
mode:
authorIlias Apalodimas <ilias.apalodimas@linaro.org>2019-07-10 00:14:48 +0300
committerDavid S. Miller <davem@davemloft.net>2019-07-09 14:46:40 -0700
commit4831539dce552b7d47a7a3f3cbc440669a3917e2 (patch)
tree47eca0e633ef4b6235b46f09d848d7addf873cc8 /drivers/net/ethernet/socionext
parentc099a408949c443cc7c83679af314ebfc805cd1f (diff)
downloadlinux-4831539dce552b7d47a7a3f3cbc440669a3917e2.tar.bz2
net: netsec: remove superfluous if statement
While freeing tx buffers the memory has to be unmapped if the packet was an skb or was used for .ndo_xdp_xmit using the same arguments. Get rid of the unneeded extra 'else if' statement Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/socionext')
-rw-r--r--drivers/net/ethernet/socionext/netsec.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index c3a4f86f56ee..7f9280f1fb28 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -654,12 +654,12 @@ static bool netsec_clean_tx_dring(struct netsec_priv *priv)
eop = (entry->attr >> NETSEC_TX_LAST) & 1;
dma_rmb();
- if (desc->buf_type == TYPE_NETSEC_SKB)
+ /* if buf_type is either TYPE_NETSEC_SKB or
+ * TYPE_NETSEC_XDP_NDO we mapped it
+ */
+ if (desc->buf_type != TYPE_NETSEC_XDP_TX)
dma_unmap_single(priv->dev, desc->dma_addr, desc->len,
DMA_TO_DEVICE);
- else if (desc->buf_type == TYPE_NETSEC_XDP_NDO)
- dma_unmap_single(priv->dev, desc->dma_addr,
- desc->len, DMA_TO_DEVICE);
if (!eop)
goto next;