diff options
| author | Edward Cree <ecree@solarflare.com> | 2017-01-04 15:10:56 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-04 14:18:19 -0500 |
| commit | 4fdda95893de776a8efdf661bbf0e338f2f13dcb (patch) | |
| tree | 401489055ed33d8fb743ab345e147a57729b9e59 /drivers/net/ethernet/sfc/ef10.c | |
| parent | aa9773be2ad5afe7acc186aedbf3b4857611d4ed (diff) | |
| download | linux-4fdda95893de776a8efdf661bbf0e338f2f13dcb.tar.bz2 | |
sfc: don't report RX hash keys to ethtool when RSS wasn't enabled
If we failed to set up RSS on EF10 (e.g. because firmware declared
RX_RSS_LIMITED), ethtool --show-nfc $dev rx-flow-hash ... should report
no fields, rather than confusingly reporting what fields we _would_ be
hashing on if RSS was working.
Fixes: dcb4123cbec0 ("sfc: disable RSS when unsupported")
Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc/ef10.c')
| -rw-r--r-- | drivers/net/ethernet/sfc/ef10.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index de2947ccc5ad..5eb0e684fd76 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc/ef10.c @@ -1323,7 +1323,8 @@ static int efx_ef10_init_nic(struct efx_nic *efx) } /* don't fail init if RSS setup doesn't work */ - efx->type->rx_push_rss_config(efx, false, efx->rx_indir_table); + rc = efx->type->rx_push_rss_config(efx, false, efx->rx_indir_table); + efx->rss_active = (rc == 0); return 0; } |