diff options
author | Duoming Zhou <duoming@zju.edu.cn> | 2022-05-17 09:25:30 +0800 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-05-17 17:55:53 -0700 |
commit | 23dd4581350d4ffa23d58976ec46408f8f4c1e16 (patch) | |
tree | 7a5c5ce71ec4c15d5e35d434cb55004059076a33 /drivers/net/ethernet/mellanox/mlx5 | |
parent | 5361448e45fac6fb96738df748229432a62d78b6 (diff) | |
download | linux-23dd4581350d4ffa23d58976ec46408f8f4c1e16.tar.bz2 |
NFC: nci: fix sleep in atomic context bugs caused by nci_skb_alloc
There are sleep in atomic context bugs when the request to secure
element of st-nci is timeout. The root cause is that nci_skb_alloc
with GFP_KERNEL parameter is called in st_nci_se_wt_timeout which is
a timer handler. The call paths that could trigger bugs are shown below:
(interrupt context 1)
st_nci_se_wt_timeout
nci_hci_send_event
nci_hci_send_data
nci_skb_alloc(..., GFP_KERNEL) //may sleep
(interrupt context 2)
st_nci_se_wt_timeout
nci_hci_send_event
nci_hci_send_data
nci_send_data
nci_queue_tx_data_frags
nci_skb_alloc(..., GFP_KERNEL) //may sleep
This patch changes allocation mode of nci_skb_alloc from GFP_KERNEL to
GFP_ATOMIC in order to prevent atomic context sleeping. The GFP_ATOMIC
flag makes memory allocation operation could be used in atomic context.
Fixes: ed06aeefdac3 ("nfc: st-nci: Rename st21nfcb to st-nci")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220517012530.75714-1-duoming@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx5')
0 files changed, 0 insertions, 0 deletions